Use "marblewidget" target again instead of var ${MARBLEWIDGET}
ClosedPublic
Actions

Authored by kossebau on Aug 7 2016, 3:18 PM.

Details

Reviewers

sanjibanb
nienhueser
rahn
shentey

Group Reviewers

Marble

Commits

R34:67e3229152d5: Use "marblewidget" target again instead of var ${MARBLEWIDGET}

Summary

It is just the targetname, use target property OUTPUT_NAME to control
the actual library name

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 5716.Aug 7 2016, 3:18 PM

kossebau retitled this revision from to Use "marblewidget" target again instead of var ${MARBLEWIDGET}.

kossebau updated this object.

kossebau added reviewers: Marble, rahn, sanjibanb, shentey, nienhueser.

Looks good.

This revision is now accepted and ready to land.Aug 7 2016, 4:06 PM

Closed by commit R34:67e3229152d5: Use "marblewidget" target again instead of var ${MARBLEWIDGET} (authored by kossebau). · Explain WhyAug 7 2016, 5:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			MarbleMacros.cmake (10 lines)
M			examples/cpp/animation-video/CMakeLists.txt (2 lines)
M			examples/cpp/basic-routing/CMakeLists.txt (2 lines)
M			examples/cpp/custom-layers/CMakeLists.txt (2 lines)
M			examples/cpp/geopainter/CMakeLists.txt (2 lines)
M			examples/cpp/hello-marble/CMakeLists.txt (2 lines)
M			examples/cpp/kml-inspector/CMakeLists.txt (2 lines)
M			examples/cpp/kml-screenshot/CMakeLists.txt (2 lines)
M			examples/cpp/map-controls/CMakeLists.txt (2 lines)
M			examples/cpp/map-properties/CMakeLists.txt (2 lines)
M			examples/cpp/marble-game/CMakeLists.txt (6 lines)
M			examples/cpp/marbleQuick2/CMakeLists.txt (7 lines)
M			examples/cpp/overlay-rendering/CMakeLists.txt (2 lines)
M			examples/cpp/pie-charts/CMakeLists.txt (2 lines)
M			examples/cpp/reverse-geocoding/CMakeLists.txt (2 lines)
M			examples/cpp/route-image/CMakeLists.txt (2 lines)
M			examples/cpp/search/CMakeLists.txt (2 lines)
M			examples/cpp/squad-interpolation/CMakeLists.txt (2 lines)
M			examples/cpp/tour-preview/CMakeLists.txt (2 lines)
M			examples/cpp/vehicletracking/CMakeLists.txt (2 lines)
M			src/apps/behaim/CMakeLists.txt (2 lines)
M			src/apps/marble-kde/CMakeLists.txt (6 lines)
M			src/apps/marble-maps/CMakeLists.txt (2 lines)
M			src/apps/marble-qt/CMakeLists.txt (2 lines)
M			src/apps/marble-ui/CMakeLists.txt (2 lines)
M			src/bindings/python/CMakeLists.txt (2 lines)
M			src/lib/marble/CMakeLists.txt (35 lines)
M			src/lib/marble/declarative/CMakeLists.txt (2 lines)
M			src/plasmarunner/CMakeLists.txt (2 lines)
M			src/plugins/designer/latloneditwidget/CMakeLists.txt (2 lines)
M			src/plugins/runner/gpx/CMakeLists.txt (2 lines)
M			src/thumbnailer/CMakeLists.txt (2 lines)
M			tools/constellations2kml/CMakeLists.txt (2 lines)
M			tools/dateline/CMakeLists.txt (2 lines)
M			tools/kml2cache/CMakeLists.txt (2 lines)
M			tools/kml2kml/CMakeLists.txt (2 lines)
M			tools/mapreproject/CMakeLists.txt (2 lines)
M			tools/maptheme-previewimage/CMakeLists.txt (2 lines)
M			tools/mbtile-import/CMakeLists.txt (2 lines)
M			tools/osm-addresses/CMakeLists.txt (8 lines)
M			tools/osm-simplify/CMakeLists.txt (2 lines)
M			tools/osm-sisyphus/CMakeLists.txt (2 lines)
M			tools/poly2kml/CMakeLists.txt (2 lines)
M			tools/shp2pn2/CMakeLists.txt (2 lines)
M			tools/tilecreator-srtm2/CMakeLists.txt (2 lines)
M			tools/tilecreator/CMakeLists.txt (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5716	ac08536		Aug 7 2016, 3:18 PM	★	★
Diff 2	5720	56615a9	rMARBLE67e3229152d55488d4af58010f1e65b0dc5570c7	Aug 7 2016, 5:11 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a7e909372a4f	75bb5e20c67a	ac08536d2604	Friedrich W. H. Kossebau	Use "marblewidget" target again instead of var ${MARBLEWIDGET} (Show More…)	Aug 7 2016, 2:38 PM