Differential D23654

Fix places text when the URL has a trailing slash
ClosedPublic
Actions

Authored by elvisangelaccio on Sep 1 2019, 8:35 PM.

Details

Reviewers
ngraham
Commits
R318:c5a713763daf: Fix places text when the URL has a trailing slash
Summary

QUrl::fileName() returns an empty string if the URL ends with a slash.

Test Plan
  1. Run dolphin /tmp from command line
  2. Right-click from viewport and click 'Add to Places'

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15969
Build 15987: arc lint + arc unit
elvisangelaccio created this revision.Sep 1 2019, 8:35 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 1 2019, 8:35 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Sep 1 2019, 8:35 PM
ngraham accepted this revision.Sep 1 2019, 11:44 PM

Stable branch, even?

This revision is now accepted and ready to land.Sep 1 2019, 11:44 PM
Closed by commit R318:c5a713763daf: Fix places text when the URL has a trailing slash (authored by elvisangelaccio). · Explain WhySep 2 2019, 7:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinviewcontainer.cpp (2 lines)

Diff 65177

View Options

src/dolphinviewcontainer.cpp

Loading...