Differential D23648

Replace the stop button of the media preview by a pause button
ClosedPublic
Actions

Authored by meven on Sep 1 2019, 3:01 PM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:9996b1f89c70: Replace the stop button of the media preview by a pause button
Summary

Stop is not as useful as paused plus it makes the button coherent with the click to play/pause feature.

CCBUG: 364957

Test Plan

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Sep 1 2019, 3:01 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 1 2019, 3:01 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Sep 1 2019, 3:01 PM
meven edited the test plan for this revision. (Show Details)Sep 1 2019, 3:01 PM
ngraham accepted this revision.Sep 1 2019, 11:50 PM
ngraham added a subscriber: ngraham.

LGTM

This revision is now accepted and ready to land.Sep 1 2019, 11:50 PM
Closed by commit R318:9996b1f89c70: Replace the stop button of the media preview by a pause button (authored by meven). · Explain WhySep 2 2019, 5:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65190

View Options

src/panels/information/phononwidget.h

Loading...
View Options

src/panels/information/phononwidget.cpp

Loading...