Differential D23646

Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)
ClosedPublic
Actions

Authored by kossebau on Sep 1 2019, 1:34 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R39:ede4725394e9: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)
Summary

GIT_SILENT

Diff Detail

Repository
R39 KTextEditor
Branch
leftrefnotsplit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15944
Build 15962: arc lint + arc unit
kossebau created this revision.Sep 1 2019, 1:34 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 1 2019, 1:34 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 1 2019, 1:34 PM
kossebau added inline comments.Sep 1 2019, 1:35 PM
src/view/kateviewhelpers.cpp
1191

Refactoring to one static object will be separate commit.

cullmann accepted this revision.Sep 1 2019, 4:52 PM
cullmann added a subscriber: cullmann.

ok

src/view/kateviewhelpers.cpp
1191

I would have no issue with this to be in this commit ;=)
That saves me review time :P

This revision is now accepted and ready to land.Sep 1 2019, 4:52 PM
Closed by commit R39:ede4725394e9: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0) (authored by kossebau). · Explain WhySep 1 2019, 6:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65125

View Options

src/utils/katetemplatehandler.cpp

Loading...
View Options

src/view/kateviewhelpers.cpp

Loading...
View Options

src/vimode/emulatedcommandbar/commandmode.cpp

Loading...