Details
Details
- Reviewers
cullmann - Group Reviewers
Kate - Commits
- R39:a5783ba11943: Use QString::count(QChar) over QString::split().length() - 1
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/vimode/modes/normalvimode.cpp | ||
---|---|---|
3844 | you didn't port this one to count? |
src/vimode/modes/normalvimode.cpp | ||
---|---|---|
3844 | Guess the complete change missed to enter the commit, and review did not catch it, |
src/vimode/modes/normalvimode.cpp | ||
---|---|---|
3844 | Ah, no, textLines.last().length() needs the string section, so just a plain count would not be enough, only if combining with a QString::section call later, I now remember. So rather something where I messed up during patch juggling. Perhaps still can be µ-optimized with using lastindexof instead :) |