Rename ShellClient to XdgShellClient
Needs ReviewPublic

Authored by zzag on Fri, Aug 30, 10:09 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

Rename ShellClient to XdgShellClient in order to reflect that it
represents only xdg-shell clients.

Test Plan

Compiles, tests still pass.

Diff Detail

Repository
R108 KWin
Branch
drop-wl-shell
Lint
Lint ErrorsExcuse: cppcheck doesn't understand std::tie()
SeverityLocationCodeMessage
Errorautotests/integration/kwin_wayland_test.h:214CppcheckunknownMacro
Errorautotests/integration/xdgshellclient_rules_test.cpp:406CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:407CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:485CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:486CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:545CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:546CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:686CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:687CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:1953CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:1954CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2006CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2007CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2063CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2064CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2181CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2182CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2264CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2265CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2310CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2311CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2358CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2359CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2452CppcheckdoubleFree
Errorautotests/integration/xdgshellclient_rules_test.cpp:2453CppcheckdoubleFree
Unit
No Unit Test Coverage
Build Status
Buildable 15872
Build 15890: arc lint + arc unit
zzag created this revision.Fri, Aug 30, 10:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptFri, Aug 30, 10:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Fri, Aug 30, 10:09 PM
zzag added a comment.Fri, Aug 30, 10:16 PM

I'm not sure what parent revision has to be. :|

My local branch looks like this at the moment

* fbb743f59 - (37 minutes ago) Rename ShellClient to XdgShellClient - Vlad Zagorodniy (HEAD -> drop-wl-shell, github/drop-wl-shell)                                                                                    
* 864a19944 - (27 hours ago) [wayland] Drop xdg-shell v5 support - Vlad Zagorodniy                                                                                                                                     
* 3e633bc12 - (33 hours ago) [tests] Drop wl-shell test client - Vlad Zagorodniy                                                                                                                                       
* 2f2c9b1f0 - (2 days ago) [effects/slidingpopups] Don't start animation if there is no slide edge - Vlad Zagorodniy
* 336154ca5 - (2 days ago) [platforms/wayland] Drop wl-shell support - Vlad Zagorodniy
* 522673b0e - (3 days ago) [wayland] Drop wl-shell support - Vlad Zagorodniy
* cd608fd07 - (3 days ago) [autotests] Don't test wl-shell clients - Vlad Zagorodniy
* 91d6d9dd7 - (5 days ago) Port QPA away from Wayland - Vlad Zagorodniy