Differential D23583

[Notifications] Group only same origin and show it in heading
ClosedPublic
Actions

Authored by broulik on Aug 30 2019, 2:19 PM.

Details

Reviewers
nicolasfella
davidedmundson
ngraham
Group Reviewers
Plasma
VDG
Commits
R120:ee787241bfff: [Notifications] Group only same origin and show it in heading
Summary

This makes it group notifications of different "origins" not group together, e.g. a FooApp notifications from phone A won't be grouped together with FooApp notifications from phone B. Also, email notifications from different accounts wouldn't be grouped together.
Also, show the origin in the grouped header.

Test Plan
  • Got a few messages on my phone, show a title now

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 30 2019, 2:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 30 2019, 2:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 30 2019, 2:19 PM
broulik updated this revision to Diff 64998.Aug 30 2019, 2:23 PM
  • Actually route it through
davidedmundson accepted this revision.Aug 30 2019, 3:22 PM
This revision is now accepted and ready to land.Aug 30 2019, 3:22 PM
ngraham accepted this revision.Aug 30 2019, 7:10 PM
Closed by commit R120:ee787241bfff: [Notifications] Group only same origin and show it in heading (authored by broulik). · Explain WhyAug 30 2019, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65013

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...
View Options

libnotificationmanager/notificationgroupingproxymodel.cpp

Loading...