Initial rewrite of worldclock plasmoid and a new worldmap plasma "wallpaper"
ClosedPublic

Authored by kossebau on Aug 4 2016, 1:51 PM.

Details

Summary
  • installs a plasma-specific marble qml plugin in a private namespace
  • exposes the property "radius" on MarbleQuickItem
  • removes unused, but now conflicting Q_PLUGIN_METADATA macro from MarbleDeclarativePlugin (which is currently only part of a shared lib)
  • some features of old worldclock plasmoid still TODO:
    • support for timezones
    • setting a lat/lon to center on

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau retitled this revision from to Initial rewrite of worldclock plasmoid and a new worldmap plasma "wallpaper".Aug 4 2016, 1:51 PM
kossebau updated this object.
kossebau added reviewers: Marble, rahn, nienhueser, sanjibanb.
kossebau updated this revision to Diff 5682.Aug 4 2016, 3:32 PM

Minor improvements

nienhueser added inline comments.Aug 6 2016, 12:12 PM
src/plasma/applets/worldclock/Messages.sh
3

shouldn't it be "${podir}" to deal with potential spaces?

src/plasma/wallpapers/worldmap/metadata.desktop
10

Ain't that LGPL here also?

kossebau added inline comments.Aug 6 2016, 2:14 PM
src/plasma/applets/worldclock/Messages.sh
3

I would guess as well, but then any other Messages.sh I saw in KDE projects also have it plain, without quotes, so I follow that for consistency here.

src/plasma/wallpapers/worldmap/metadata.desktop
10

Yes, fixed.

kossebau updated this revision to Diff 5705.Aug 6 2016, 2:14 PM

fixed license key for wallpaper plugin

nienhueser accepted this revision.Aug 6 2016, 2:40 PM

Please push.

This revision is now accepted and ready to land.Aug 6 2016, 2:40 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.