usr_bin.txt is the content of my /usr/bin as a somewhat realistic input
for the sorting function
citynames.txt is a subsample of city names (as an example of unicode
strings which one might encounter)
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- benchmark
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15709 Build 15727: arc lint + arc unit
Comment Actions
The micro benchmark is rather simplistic, but I hope still better than nothing (and I want it to show that D23507 makes sense)
Comment Actions
Do you have the results ?
| src/tests/CMakeLists.txt | ||
|---|---|---|
| 42 | Make it optional to build benchmark, perhaps in its own folder. | |
Comment Actions
Sorry, this fell by the wayside. I've had the results attached in a comment in https://phabricator.kde.org/D23507 for my system. I'll make the benchmark optional real soon™…
| src/tests/CMakeLists.txt | ||
|---|---|---|
| 42 | Why? We already run another benchmark (kfileitemmodelbenchmark) unconditionally. | |
| src/tests/dolphinsortingbenchmark.cpp | ||
| 30 | Use descriptive variable names (e.g. file). | |
| 31 | Missing const | |
| 34–35 | Missing braces | |
| 56 | Not sure what you mean with optimizazion barrier. Can you explain why there is no QVERIFY here? | |
| src/tests/CMakeLists.txt | ||
|---|---|---|
| 42 | Morst benchmarks have no assertions. | |