Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window
ClosedPublic
Actions

Authored by graesslin on Aug 3 2016, 2:15 PM.

Details

Reviewers

sebas
hein
bshah

Group Reviewers

Plasma
KWin

Commits

R108:671740dc70c4: Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window

Summary

This fixes a regression introduced with a1afeded6ae63e47d39fc08480e929c0451c51e8.
The connections were setup every the windowShown signal got emitted.
This caused effects to get multiple singals and start multiple animations
which then do not get cancelled correctly.

The incorrect behavior was most visible in the translucency effect which
did not cancel the move animation and the window stayed translucent.

BUG: 366081

Test Plan

New test case which simulates the behavior of the translucency
effect.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 5655.Aug 3 2016, 2:15 PM

graesslin retitled this revision from to Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma, sebas.

Restricted Application added a project: KWin. · View Herald TranscriptAug 3 2016, 2:15 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

Works for me.

This revision is now accepted and ready to land.Aug 3 2016, 3:16 PM

My desperate attempt to reproduce bug with this applied doesn't seem to workout.. so "ship it"

Seems to fix the problem for me, too.

Closed by commit R108:671740dc70c4: Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window (authored by graesslin). · Explain WhyAug 3 2016, 3:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/CMakeLists.txt (1 line)
A	M	autotests/integration/effects/CMakeLists.txt (3 lines)
A	M	autotests/integration/effects/translucency_test.cpp (185 lines)
M		effectloader.h (2 lines)
M		effects.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5655	4c6c4e6		Aug 3 2016, 2:15 PM	★	★
Diff 2	5656	4c6c4e6	rKWIN671740dc70c4d2fb091320c0da564cf2ea6029b2	Aug 3 2016, 2:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ac5618d415ec	639319bb0c0b	4c6c4e6717f3	Martin Gräßlin	Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window (Show More…)	Aug 3 2016, 2:12 PM