Differential D23405

Add properties action to trash in Places panel
Needs RevisionPublic
Actions

Authored by shubham on Aug 24 2019, 4:31 PM.

Details

Reviewers
elvisangelaccio
ngraham

Diff Detail

Repository
R318 Dolphin
Branch
trash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15585
Build 15603: arc lint + arc unit
shubham created this revision.Aug 24 2019, 4:31 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 24 2019, 4:31 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
shubham requested review of this revision.Aug 24 2019, 4:31 PM
shubham updated this revision to Diff 64495.Aug 24 2019, 4:36 PM

Remove unrelated change

shubham updated this revision to Diff 64496.Aug 24 2019, 4:37 PM

Fix more unrelated change

ngraham requested changes to this revision.Aug 24 2019, 8:43 PM

I suspect that the trash didn't have a properties item because its properties window is completely worthless and full of inaccurate information:

Before this can land, I'd want the properties window for trash:/ made actually useful (or at least accurate) first.

This revision now requires changes to proceed.Aug 24 2019, 8:43 PM

Revision Contents
Changeset List

PathPackages
Msrc/panels/places/placespanel.cpp (9 lines)

Diff 64496

View Options

src/panels/places/placespanel.cpp

Loading...