Clean up not needed Q_INVOKABLE
ClosedPublic

Authored by meven on Sat, Aug 24, 7:05 AM.

Details

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Sat, Aug 24, 7:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Aug 24, 7:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Sat, Aug 24, 7:05 AM
broulik accepted this revision.Sat, Aug 31, 7:55 AM

Lovely!

Modules/energy/package/contents/ui/main.qml
101–102

You could probably move that into a function initCurrent() or similar and call it in both this and the change handler

You can also probably cache the index in a variable to only query it once

This revision is now accepted and ready to land.Sat, Aug 31, 7:55 AM
meven updated this revision to Diff 65035.Sat, Aug 31, 8:17 AM

Add a function initCurrentBattery to initialize currentBattery property and associated ones

meven marked an inline comment as done.Sat, Aug 31, 8:20 AM
meven updated this revision to Diff 65038.Sat, Aug 31, 8:24 AM

Remove unnecessary root.

This revision was automatically updated to reflect the committed changes.