Modules/energy/package/contents/ui/main.qml
97	You could probably move that into a `function initCurrent()` or similar and call it in both this and the change handler You can also probably cache the `index` in a variable to only query it once

This revision is now accepted and ready to land.Aug 31 2019, 7:55 AM

Add a function initCurrentBattery to initialize currentBattery property and associated ones

rebase

meven marked an inline comment as done.Aug 31 2019, 8:20 AM

Remove unnecessary root.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			Modules/energy/batterymodel.h (6 lines)
M			Modules/energy/batterymodel.cpp (39 lines)
M			Modules/energy/kcm.cpp (2 lines)
M			Modules/energy/package/contents/ui/main.qml (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64457	8290b7e		Aug 24 2019, 7:05 AM	★	★
Diff 2	65035	b154d70	Add a function initCurrentBattery to initialize currentBattery property and…	Aug 31 2019, 8:17 AM	★	★
Diff 3	65036	8eb85b3	rebase	Aug 31 2019, 8:18 AM	★	★
Diff 4	65038	8eb85b3	Remove unnecessary root.	Aug 31 2019, 8:24 AM	★	★
Diff 5	65039	8eb85b3	R102:3d94131ee08a45b790c8d84c44c0ec16766e0106	Aug 31 2019, 8:25 AM	★	★

Clean up not needed Q_INVOKABLE
ClosedPublic
Actions

Details