Add FictionBook 2 icons
ClosedPublic

Authored by yurchor on Tue, Aug 20, 6:22 PM.

Details

Summary

FictionBook 2 icons from Okular (design by Vladimir Prohorenkov, my implementation).

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Tue, Aug 20, 6:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Aug 20, 6:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
yurchor requested review of this revision.Tue, Aug 20, 6:22 PM
yurchor edited the test plan for this revision. (Show Details)Tue, Aug 20, 6:23 PM
yurchor updated this revision to Diff 64152.Tue, Aug 20, 6:53 PM

Remove extra font dependencies

ngraham requested changes to this revision.Tue, Aug 20, 7:44 PM
ngraham added a subscriber: ngraham.

Interesting design! However having that triangular part jutting out of the side is pretty unusual, and not seen in any other MimeType icons. Maybe move that shape fully inside and copy the visual style of existing book-style icons, such as application-pdf application-epub+zip . Generally they have a sort of book-like appearance with a line on the left side for the book's spine.

This revision now requires changes to proceed.Tue, Aug 20, 7:44 PM
yurchor updated this revision to Diff 64186.Wed, Aug 21, 9:35 AM

Be consistent with existing book-style icons.

yurchor edited the test plan for this revision. (Show Details)Wed, Aug 21, 9:36 AM

Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :)

yurchor edited the test plan for this revision. (Show Details)Wed, Aug 21, 1:58 PM
yurchor updated this revision to Diff 64206.Wed, Aug 21, 1:59 PM

Total unbrutalization

Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon.

yurchor edited the test plan for this revision. (Show Details)Wed, Aug 21, 2:34 PM
yurchor updated this revision to Diff 64212.Wed, Aug 21, 2:35 PM

Use blue background

Reduce the size of the SVGs by optimizing them with one of these tools: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

yurchor updated this revision to Diff 64236.Wed, Aug 21, 5:28 PM

Optimize SVG with svgcleaner + svgo

ndavis requested changes to this revision.Thu, Aug 22, 7:37 AM

Upon closer inspection, I found a few issues that need to be fixed.

Blur can't be used because the Qt SVG renderer doesn't support it. You'll have to use linear or radial gradients for shadows instead.

Left: Qt, Right: Inkscape

The 16 and 22 px icons are using the wrong style. These are more similar to other mimetype icons of those sizes:



The "fb 2" is not always easy to read. I suggest aligning the characters to the grid. For the 32px version, you could just copy in the 16px version from my attached archives since the alignment is already done.

Breeze Dark icons are also missing.

This revision now requires changes to proceed.Thu, Aug 22, 7:37 AM
yurchor abandoned this revision.Thu, Aug 22, 7:39 AM

I have no time to redo this now. Sorry.

yurchor reclaimed this revision.Thu, Aug 22, 9:59 AM

Unexpected free time.

This revision now requires changes to proceed.Thu, Aug 22, 9:59 AM
yurchor updated this revision to Diff 64281.Thu, Aug 22, 10:03 AM

Realign 32px versions, replace 16px and 22px with icons proposed by Noah Davis, add dark versions

Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop shadow. I only used different colors on the 16 and 22 px icons because they don't have a background.

yurchor updated this revision to Diff 64286.Thu, Aug 22, 10:44 AM

Use black "fb" for 32px and 64px breeze-dark

ndavis accepted this revision.Thu, Aug 22, 10:56 AM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 22, 5:06 PM
This revision was automatically updated to reflect the committed changes.