BUG: 405956
Details
- Reviewers
ngraham mart - Group Reviewers
Plasma VDG - Commits
- R124:de351c8ed6c3: Add "Show intro page" button to System Settings sidebar
Open System Settings and click on the "Show intro page" button.
Diff Detail
- Repository
- R124 System Settings
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
when the intro page gets shown, (again binded from a bool property arriving from c++)
categoryView.currentIndex should be set to -1,
and systemsettings.activeCategory to -1 as well
sidebar/SidebarMode.cpp | ||
---|---|---|
439 | this should be a bool property setter | |
sidebar/package/contents/ui/CategoriesPage.qml | ||
42–43 | would be nice to have this disabled when on intro page. | |
72 | I would prefer overflow-menu |
there *may* be some changes needing to be done on SidebarMode::setActiveCategory for that to work, but try to do that, then wel'll see
sidebar/package/contents/ui/CategoriesPage.qml | ||
---|---|---|
72 | This is just moving the existing item around, which already uses the hamburger menu icon (appropriately IMO). |
can you take a look? should be fairly simple
const int newCategoryRow = to have -1 when the passed cat is -1
also, SidebarMode::changeModule to get special casing for invalid qmodelindexes
Looks like this is more complicated than I thought. If someone wants to comandeer this revision then please do.
Thanks! The only issue that's left now is that the subcategory doesn't get reset (when going into for example Application Style and then pressing the button).
Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? (Goal: Consistency)
i strongly disagree, it's the opposite of every other kirigami app, and i really want to change it back.
But then Kirigami is the opposite of other apps that have their hamburger menus on the right (Dolphin, Firefox, GNOME apps). We need to sort this out.
I don't think it's an absolute rule for every app, but systemsettings uses the column layout with drill down and toolbars contextual only to the column they are on top of.
For pages toolbars of applications that use column based navigation, action buttons are on the right, title or a widget that replaces the title (like a search field) is on the left (which, is pretty much the android layout, or chat apps like whatsapp and telegram on any platform)
I would be hurted already a bit less from that systemsettings layout if that menu button was a ... icon instead, which is then commonly used by such apps.
For those column based layouts with column-specific toolbars i kinda see an "app-global" menu icon only on the left, i don't think it would ever work on the right at all.
Also because the pattern is from left column: more generic stuff, and as goes right, more drilled down, narrow-topic content
Dolphin toolbar i see it more like a different beast, a "global" toolbar that doesn't have anything to do with those context specific ones and has different rules.
There, is true that probably the menu button in front of the back button would be kinda strange, especially because the most used button is probably indeed, the back button and the menu button just once in a blue moon. (tough for dolphin as well, i think i would prefer a lot the ... as chromium does)
I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting a little mini-toolbar above the app's sidebar that's separate from the toolbar above the view, which would then contain only view-specific actions. This is becoming pretty common and Kirigami apps can do this easily but our QWidgets apps can't do it as easily. Maybe it's time to look into that.
Either way I guess I can get on board with having the hamburger menu on the left here. We'll also need to do the same thing for Discover then.
Implemented the requested change for Systemsettings (https://commits.kde.org/systemsettings/ea0f40c9c03b679ff23688d1eabda61c972f6bc1) and Discover (https://commits.kde.org/discover/b8dfc2d02cc2ac8e7416923e00454a7dc8020f7b).
To me we should look more into the differences of global vs page specific toolbars
I feel that the 2 different types of toolbars in this screenshot (whatsapp,telegram and kirigami gallery vs libreoffice and dolphin)
both make sense to exist and coexist (even in the same app at once if necessary) and they call for different rules and behavior
and for the global menu case, an hamburgher menu at the top right makes sense (tough to me could well be the ... icon as is kinda "actions that didn't fit the global toolbar")
I would be ok if it was wound a way that visually and conceptually works to move the hamburger of column view apps elsewhere, can't think of any
Either way I guess I can get on board with having the hamburger menu on the left here. We'll also need to do the same thing for Discover then.
Discover doesn't have any global menu i think? (iirc only an home button?) in the case of discover the "global thing" that kinda replaces the menubar becomes the sidebar when small or mobile