JavaScript: remove unnecessary "Conditional Expression" context
ClosedPublic
Actions

Authored by nibags on Aug 19 2019, 8:05 PM.

Details

Reviewers

dhaumann
cullmann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:4bc333ee2509: JavaScript: remove unnecessary "Conditional Expression" context

Summary

The "Conditional Expression" context generates bugs when using JavaScript as an embedded language (for example, in HTML or CoffeeScript), since it prevents closing the JavaScript block after writing "?".

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nibags created this revision.Aug 19 2019, 8:05 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 19 2019, 8:05 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

nibags requested review of this revision.Aug 19 2019, 8:05 PM

Harbormaster completed remote builds in B15317: Diff 64068.Aug 19 2019, 8:05 PM

Looks very reasonable to me, thanks.

This revision is now accepted and ready to land.Aug 20 2019, 7:14 AM

Closed by commit R216:4bc333ee2509: JavaScript: remove unnecessary "Conditional Expression" context (authored by nibags). · Explain WhyAug 20 2019, 11:04 AM

This revision was automatically updated to reflect the committed changes.

nibags mentioned this in D25503: JavaScript: move keywords from TypeScript and other improvements.Nov 24 2019, 10:02 AM

cullmann mentioned this in R216:9c64fb507253: JavaScript: move keywords from TypeScript and other improvements.Nov 26 2019, 6:19 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/test.htm.fold (7 lines)
M			autotests/html/test.htm.html (7 lines)
M			autotests/input/test.htm (7 lines)
M			autotests/reference/highlight.js.ref (8 lines)
M			autotests/reference/highlight.qml.ref (6 lines)
M			autotests/reference/test.htm.ref (7 lines)
M			data/syntax/javascript.xml (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64068	635cb83		Aug 19 2019, 8:05 PM	★	★
Diff 2	64102	0edc0cb	R216:4bc333ee25095509091d3a10e069b2f49b75a7f1	Aug 20 2019, 11:04 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1d56393a3e08	918fbc12a0c3	635cb83670f9	Nibaldo González	JavaScript: remove unnecessary "Conditional Expression" context (Show More…)	Aug 19 2019, 8:04 PM