[Battery Monitor] Call battery capacity "Capacity degradation" for better clarity
ClosedPublic

Authored by ngraham on Mon, Aug 19, 7:12 PM.

Details

Summary

Companion patch to D23270

The same logic explained in D23270 applies here: using the text "Capacity degradation"
is much clearer than "capacity" when referring to how much of the battery's original
capacity is remaining due to degradation.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mon, Aug 19, 7:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Aug 19, 7:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Aug 19, 7:12 PM
ngraham retitled this revision from [Battery Monitor] Call battery capacity "degredation" for better clarity to [Battery Monitor] Call battery capacity "degradation" for better clarity.
broulik accepted this revision.Tue, Aug 20, 6:43 AM
broulik added inline comments.
applets/batterymonitor/package/contents/ui/logic.js
45–46

I think this needs some explanatory context

This revision is now accepted and ready to land.Tue, Aug 20, 6:43 AM
filipf accepted this revision.Tue, Aug 20, 8:23 AM
filipf added a subscriber: filipf.

+1, same reasoning as in D23270#514978.

ngraham updated this revision to Diff 64123.Tue, Aug 20, 2:00 PM
ngraham marked an inline comment as done.

Add context

aspotashev added a subscriber: aspotashev.EditedTue, Aug 20, 2:36 PM

I disagree with this change, see D23270#515102

ngraham updated this revision to Diff 64142.Tue, Aug 20, 5:42 PM

Use the superior agreed-upon string "Capacity degradation"

ngraham edited the test plan for this revision. (Show Details)Tue, Aug 20, 5:44 PM
ngraham retitled this revision from [Battery Monitor] Call battery capacity "degradation" for better clarity to [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.
ngraham edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.