KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED
ClosedPublic

Authored by dfaure on Aug 17 2019, 10:11 AM.

Details

Test Plan

add_compile_definitions(KWINDOWSYSTEM_NO_DEPRECATED) in CMakeLists.txt

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Aug 17 2019, 10:11 AM
dfaure created this revision.
dfaure updated this revision to Diff 63899.Aug 17 2019, 10:11 AM
dfaure retitled this revision from KWindowSystem: fix compilation without KWINDOWSYSTEM_NO_DEPRECATED to KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.

fix description

dfaure added inline comments.Sat, Aug 17, 9:08 PM
src/kstartupinfo.cpp
717

Similar code in kuniqueapplication.cpp has the comment "// use extra X connection".
Any idea why? (git log doesn't help, commit e5b75f8409e7f in 2001)
Do we need to do that with xcb too?

dfaure added inline comments.Sun, Aug 18, 7:40 AM
src/kstartupinfo.cpp
717

Ah, I think I know why. That's because in kuniqueapplication, this happens right after fork(), and we're in the child, so we better use a different connection to X.

I bet this got copy/pasted here for no good reason.

zzag accepted this revision.Tue, Aug 20, 7:20 PM
This revision is now accepted and ready to land.Tue, Aug 20, 7:20 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Aug 22, 12:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript