Differential D22976

Fix compilation
ClosedPublic
Actions

Authored by ngraham on Aug 6 2019, 7:32 PM.

Details

Reviewers
aacid
Group Reviewers
Plasma
Commits
R120:1fcbf707b41d: Fix compilation
R120:0c4ec1c4af05: Fix compilation
Summary

Without this patch, plasma-workspace fails to compile for me with the following error:

In file included from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/moc_windowsrunner.cpp:10,
                 from /home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/mocs_compilation.cpp:2:
/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/../../../../../../src/plasma-workspace/runners/windows/windowsrunner.h:61:9: error: ‘QMutex’ does not name a type
   61 |         QMutex m_mutex;
      |         ^~~~~~
Test Plan

It compiles now

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 6 2019, 7:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2019, 7:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 6 2019, 7:32 PM
aacid accepted this revision.Aug 6 2019, 7:33 PM
This revision is now accepted and ready to land.Aug 6 2019, 7:33 PM
Closed by commit R120:0c4ec1c4af05: Fix compilation (authored by ngraham). · Explain WhyAug 6 2019, 7:34 PM
This revision was automatically updated to reflect the committed changes.
usta added a subscriber: usta.Aug 10 2019, 5:01 AM

ben mentioned that this also needs to be cherrypicked to stable branch too.

aacid added a comment.Aug 10 2019, 9:21 AM

And what are you or ben waiting for? You've both got commit access :)

usta added a comment.Aug 10 2019, 2:19 PM
In D22976#509675, @aacid wrote:

And what are you or ben waiting for? You've both got commit access :)

@aacid:
;) in here we are in sacrifice feast , and i dont have my laptop with me ( sorry about that )

And @ngraham thank you

Revision Contents
Changeset List

PathPackages
Mrunners/windows/windowsrunner.h (2 lines)

Diff 63223

View Options

runners/windows/windowsrunner.h

Loading...