Apply the KDE HIG and make the desktop file consistent.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R133:bf5040930785: Improve the look of the Lock Screen KCM UI
Open the Lock Screen KCM.
Diff Detail
Diff Detail
- Repository
- R133 KScreenLocker
- Branch
- improved-lock-screen-kcm-ui (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14735 Build 14753: arc lint + arc unit
Comment Actions
A good future improvement would be to change "mins" and "secs" in the spinboxes to "minutes" and "seconds".
kcm/kcm.ui | ||
---|---|---|
49 ↗ | (On Diff #63030) | Capitalize Automatically |
71 ↗ | (On Diff #63030) | Capitalize On |
78 ↗ | (On Diff #63030) | While we're at it, I might rephrase this to say, "Allow unlocking without a password during the first" |
kcm/kcm.ui | ||
---|---|---|
49 ↗ | (On Diff #63030) | That was kind of an exception for just that item because it's written as a multi-part sentence. You can see in the checkbox below it that it used the normal capitalization style. |
Comment Actions
Noticed one more change I'd like to make while screenshotting it for next week's blog post. See D22934.