Improve the look of the Lock Screen KCM UI
ClosedPublic

Authored by GB_2 on Aug 3 2019, 7:21 PM.

Details

Summary

Apply the KDE HIG and make the desktop file consistent.

Test Plan

Open the Lock Screen KCM.

Diff Detail

Repository
R133 KScreenLocker
Branch
improved-lock-screen-kcm-ui (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14712
Build 14730: arc lint + arc unit
GB_2 created this revision.Aug 3 2019, 7:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 3 2019, 7:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Aug 3 2019, 7:21 PM
ngraham added a subscriber: ngraham.Aug 4 2019, 4:04 PM

A good future improvement would be to change "mins" and "secs" in the spinboxes to "minutes" and "seconds".

kcm/kcm.ui
49

Capitalize Automatically

71

Capitalize On

78

While we're at it, I might rephrase this to say, "Allow unlocking without a password during the first"

GB_2 added inline comments.Aug 4 2019, 4:53 PM
kcm/kcm.ui
49

Ok, I just followed the style from D21610, if it's wrong then it needs to be corrected ther too.

78

Ok

ngraham added inline comments.Aug 4 2019, 5:00 PM
kcm/kcm.ui
49

That was kind of an exception for just that item because it's written as a multi-part sentence. You can see in the checkbox below it that it used the normal capitalization style.

GB_2 updated this revision to Diff 63078.Aug 4 2019, 5:06 PM

Address comments

GB_2 marked 6 inline comments as done.Aug 4 2019, 5:06 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 updated this revision to Diff 63079.Aug 4 2019, 5:08 PM

Correct ki18ncp comment

ngraham accepted this revision.Aug 4 2019, 5:12 PM

LGTM! Nice work.

This revision is now accepted and ready to land.Aug 4 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Noticed one more change I'd like to make while screenshotting it for next week's blog post. See D22934.