[kcmkwin/kwinscreenedges] Improve the look of the Screen Edges and Touch Screen KCM UI
ClosedPublic

Authored by GB_2 on Sat, Aug 3, 4:14 PM.

Details

Summary

Apply the KDE HIG, use a form layout, make the desktop file consistent and make the KCM look better.


Test Plan

Open the Screen Edges and Touch Screen KCMs.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Sat, Aug 3, 4:14 PM
Restricted Application added a project: KWin. · View Herald TranscriptSat, Aug 3, 4:14 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Sat, Aug 3, 4:14 PM
GB_2 updated this revision to Diff 63028.Sat, Aug 3, 4:21 PM

Don't accidentally change ElectricBorderCornerRatio config entry name

GB_2 updated this revision to Diff 63038.Sun, Aug 4, 7:59 AM

Improve window management configuration controls

GB_2 edited the summary of this revision. (Show Details)Sun, Aug 4, 8:00 AM
zzag accepted this revision.Sun, Aug 4, 11:01 AM
zzag added a subscriber: zzag.

Please wait for input from VDG.

This revision is now accepted and ready to land.Sun, Aug 4, 11:01 AM
ngraham requested changes to this revision.Sun, Aug 4, 5:32 PM
ngraham added a subscriber: ngraham.

I would reverse the labels and text box text for the top two items so it's like this:

Maximize: [x] Windows dragged to top edge
Tile:     [x] Windows dragged to left or right edge

This feels more natural to me because it's written like a sentence ( at least in English) and also allows the UI to easily accommodate more maximize and tile actions in the future.

This revision now requires changes to proceed.Sun, Aug 4, 5:32 PM
GB_2 updated this revision to Diff 63081.Sun, Aug 4, 6:16 PM

Reverse labels

GB_2 edited the summary of this revision. (Show Details)Sun, Aug 4, 6:16 PM
ngraham accepted this revision.Sun, Aug 4, 6:22 PM

Thanks, much nicer now!

This revision is now accepted and ready to land.Sun, Aug 4, 6:22 PM
zzag accepted this revision.Sun, Aug 4, 6:24 PM
This revision was automatically updated to reflect the committed changes.