[Permissions editor] Port icons to use QIcon::fromTheme()
ClosedPublic
Actions

Authored by ngraham on Aug 3 2019, 2:30 AM.

Details

Reviewers

cfeck
davidedmundson

Group Reviewers

Frameworks

Commits

R241:100fb70e6162: [Permissions editor] Port icons to use QIcon::fromTheme()

Summary

The permissions editor was using custom low-resolution pixmaps, which did not respect
the icon theme or color scheme and frequently just looked bad, including with a high
DPI screen or when using a dark theme.

This patch ports it to use icons from the active icon theme using QIcon::fromTheme().

BUG: 407662
FIXED-IN: 5.62

Test Plan

All functionality still works.

Looks better, especially with Breeze icons, a dark color scheme, and a high DPI scale
factor:

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Aug 3 2019, 2:30 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 3 2019, 2:30 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Aug 3 2019, 2:30 AM

Harbormaster completed remote builds in B14702: Diff 63011.Aug 3 2019, 2:30 AM

That's much nicer

This revision is now accepted and ready to land.Aug 3 2019, 7:58 AM

Closed by commit R241:100fb70e6162: [Permissions editor] Port icons to use QIcon::fromTheme() (authored by ngraham). · Explain WhyAug 4 2019, 3:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
D	M	(bin)	src/widgets/images/group-grey.png
D	M	(bin)	src/widgets/images/group.png
D	M	(bin)	src/widgets/images/mask.png
D	M	(bin)	src/widgets/images/others-grey.png
D	M	(bin)	src/widgets/images/others.png
D	M	(bin)	src/widgets/images/user-grey.png
D	M	(bin)	src/widgets/images/user.png
D	M	(bin)	src/widgets/images/yes.png
D	M	(bin)	src/widgets/images/yespartial.png
M			src/widgets/kacleditwidget.cpp (76 lines)
M			src/widgets/kacleditwidget_p.h (14 lines)