Differential D22899

[SplitterProxy] Don't manually mapToGlobal
ClosedPublic
Actions

Authored by broulik on Aug 2 2019, 4:16 PM.

Details

Reviewers
hpereiradacosta
Group Reviewers
Plasma
Commits
R113:47459c65df41: [SplitterProxy] Don't manually mapToGlobal
Summary

The constructor of QMouseEvent actually expects windowPos and/or screenPos but never globalPos.
By only supplying a localPos we have Qt figure it out correctly on its own.

Test Plan

D22851 for oxygen. Compiles.

Diff Detail

Repository
R113 Oxygen Theme
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 2 2019, 4:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 2 2019, 4:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 2 2019, 4:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2019, 11:28 AM
Closed by commit R113:47459c65df41: [SplitterProxy] Don't manually mapToGlobal (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/oxygensplitterproxy.cpp (2 lines)

Diff 62987

View Options

kstyle/oxygensplitterproxy.cpp

Loading...