[SplitterProxy] Don't manually mapToGlobal
ClosedPublic

Authored by broulik on Jul 31 2019, 11:19 AM.

Details

Summary

The constructor of QMouseEvent actually expects windowPos and/or screenPos but never globalPos.
By only supplying a localPos we have Qt figure it out correctly on its own.

Test Plan
  • I can now drag the vertical splitter in QtCreator on my second 4k monitor, previously it would just snap to its leftmost position once I started moving, as the mapped coordinates became negative
  • I still have the enlarged splitter drag area provided by Breeze compared to e.g. Fusion style

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 31 2019, 11:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 31 2019, 11:19 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 31 2019, 11:19 AM
davidedmundson accepted this revision.Jul 31 2019, 12:30 PM
This revision is now accepted and ready to land.Jul 31 2019, 12:30 PM

Thanks for the fix !
Oxygen needs the same patch. Will you also push it there ?

Hugo

This revision was automatically updated to reflect the committed changes.