[Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

Authored by broulik on Jul 31 2019, 2:56 PM.



Group settings related to do not disturb mode there as wel.

Test Plan

Depends on D22856

  • Mirrored screens, unchecked checkbox, hit apply, dnd mode was exited.
  • checked checkbox again, dnd mode was entered again.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 31 2019, 2:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 31 2019, 2:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 31 2019, 2:56 PM

Hmm, this requires that the user makes the mental connection between "screens are mirrored" and "I'm delivering a presentation". Also, that mapping is not 100%; LibreOffice Impress even discourages using mirrored displays because when you use extended mode instead, the presenter's display can show notes that the audience doesn't see.

broulik added a subscriber: dfaure.Aug 2 2019, 4:13 PM

Sure, but in the non-mirrored case notifications popping up won't really be a problem as you will have your desktop with notifications alongside your notes on the laptop in front of you with just the presentation on the projector.
This feature is for when you actually show something on your desktop like we did during the sprint or as @dfaure pointed out when he demonstrates some code.

All right, makes sense. I might suggest a little UI re-work now that we have two DnD-related checkboxes next to each other:

Do not Disturb mode: [ ] Enable when screens are mirrored
                     [ ] Show critical notifications
broulik planned changes to this revision.Aug 2 2019, 4:18 PM

Good idea, will do.

broulik updated this revision to Diff 63105.Aug 5 2019, 10:12 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
  • Shuffle checkboxes around a bit
ngraham accepted this revision.Aug 5 2019, 2:45 PM
This revision is now accepted and ready to land.Aug 5 2019, 2:45 PM
This revision was automatically updated to reflect the committed changes.