| broulik |
| Plasma |
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.
Version 2 of the patch using a normal property.
We need to have the virtual so that the containment waits for the
wallpaper.
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper is pushed
| No Linters Available |
| No Unit Test Coverage |
| Buildable 14609 | |
| Build 14627: arc lint + arc unit |
+1 LGTM overall
| src/scriptengines/qml/plasmoid/wallpaperinterface.h | ||
|---|---|---|
| 52 ↗ | (On Diff #62842) | Use READ isLoading() instead of MEMBER? and unify loading vs isLoading. |
That's something I deliberately did, though it might still be stupid :)
I have a property on containment isLoading
If the containment itself is loaded and set to false but the wallpaper is not, I thought it was more correct for the loading property of the containment to return false.
| src/scriptengines/qml/plasmoid/containmentinterface.cpp | ||
|---|---|---|
| 1225 ↗ | (On Diff #62842) | Shouldn't this be |=? |
Will it? isLoading returns m_loading anyway...
it's virtual, the ContainmentInterface::isLoading does not return that.
It does, including the wallpaper, which is what we're actually after.
Do we need appletInterface.loading to be false while the wallpaper is still loading?
Do we need appletInterface.loading to be false while the wallpaper is still loading?
I think so. Most properties map 1:1 with what was explicitly set.
Without that we don't have an accessor for the containment QML code to find out what it has set itself to, which might prove problematic.