Differential D22780

KZip::openArchive: turn assert into if+return false
ClosedPublic
Actions

Authored by aacid on Jul 27 2019, 3:51 PM.

Details

Reviewers
dfaure
Commits
R243:d8e8d8993493: KZip::openArchive: turn assert into if+return false
Summary

Asserting just because you opened a broken file is not nice

Diff Detail

Repository
R243 KArchive
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14472
Build 14490: arc lint + arc unit
aacid created this revision.Jul 27 2019, 3:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 27 2019, 3:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jul 27 2019, 3:51 PM
aacid updated this revision to Diff 62651.Jul 27 2019, 3:51 PM

better tr string?

dfaure accepted this revision.Jul 27 2019, 4:51 PM
This revision is now accepted and ready to land.Jul 27 2019, 4:51 PM
aacid closed this revision.Jul 27 2019, 4:52 PM

Revision Contents
Changeset List

PathPackages
Msrc/kzip.cpp (5 lines)

Diff 62651

View Options

src/kzip.cpp

Loading...