[WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin
AbandonedPublic

Authored by kossebau on Jul 27 2019, 12:22 PM.

Details

Reviewers
None

Diff Detail

Repository
R239 KDELibs4Support
Branch
useecmaddqtdesignerplugin
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14475
Build 14493: arc lint + arc unit
kossebau created this revision.Jul 27 2019, 12:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 27 2019, 12:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jul 27 2019, 12:22 PM
kossebau updated this revision to Diff 62654.Jul 27 2019, 4:36 PM

make use of DEFAULT_ICON_DIR

kossebau abandoned this revision.Jul 28 2019, 9:59 AM

kelibs4support still sports the KDEUIMacros.cmale file, which defines a macro KDE4_ADD_WIDGET_FILES, which uses KF5DESIGNERPLUGIN_GENERATOR_EXECUTABLE, so has a runtime dependency on kdesignerplugin with the development files.
In that case it does not make that much sense to also remove it as build time dependency? Potentially resulting in packagers changing too much things, and forgetting about the run time dependency?

Thus discarding for now.