Remove dependency on kdesignerplugin
Needs ReviewPublic

Authored by arojas on Sep 14 2019, 5:12 PM.

Details

Reviewers
kossebau
Summary

Not sure what the reason was to have it here in the first place, but it doesn't seem to make sense nowadays. It adds an unnecesary build dependency on kdesignerplugin for all packages that depend on kdelibs4support.

Test Plan

Builds

Diff Detail

Repository
R239 KDELibs4Support
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Sep 14 2019, 5:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 14 2019, 5:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Sep 14 2019, 5:12 PM

It's there because one of the cmake macros kdelibs4support installs depends on its existance, see
https://phabricator.kde.org/source/kdelibs4support/browse/master/src/KDEUIMacros.cmake$166

PS: That''s also the reason why I gave up on porting kdelibs4support away from it, given the tool is leaked in the public interface by this macro (cmp. comment D22776#503175)

Does that really justify a hard dependency? It would make more sense for the dependency to be moved to the projects that do use the macro. extra-cmake-modules ships macros that call sip or doxygen and it doesn't hard depend on them.

The current macro does not check for the existence, so the dep is hard IMHO.

One could change that, but myself no energy left to work on/review such patch, all my energy would be spent to get of kdelibs4support completely in general :)