Differential D22752

[kcms/fonts] Replace warning message with inline message when applying changes
ClosedPublic
Actions

Authored by filipf on Jul 25 2019, 9:42 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
VDG
Commits
R119:aec4f2b9262f: Revert "Take in consideration flat() for the All Applications menu"
R119:eae23d5d141b: [kcms/fonts] Replace warning message with inline message when applying changes
Summary

This patch gets rid of the popup message spawned when applying changes in the Fonts KCM and instead places the very same information in an inline message.

BUG: 388433

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 25 2019, 9:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2019, 9:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jul 25 2019, 9:42 PM
filipf updated this revision to Diff 62575.Jul 25 2019, 9:44 PM

rebase on master

filipf edited the test plan for this revision. (Show Details)Jul 25 2019, 9:45 PM
filipf added reviewers: Plasma, VDG, ngraham.
filipf added a subscriber: broulik.EditedJul 25 2019, 9:47 PM

Something @broulik proposed is to have the inline message spawn right below the separator that precedes the antialiasing settings instead of at the very top.

Like this (or hacked so it's full width):

davidedmundson accepted this revision.Jul 25 2019, 10:51 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kcms/fonts/package/contents/ui/main.qml
46–48

Do we need a Layout.fillWidth here?

This revision is now accepted and ready to land.Jul 25 2019, 10:51 PM
filipf added inline comments.Jul 25 2019, 11:14 PM
kcms/fonts/package/contents/ui/main.qml
46–48

This happens without` Layout.fillWidth`

ngraham accepted this revision.Jul 26 2019, 2:25 PM

Nice improvement.

Closed by commit R119:eae23d5d141b: [kcms/fonts] Replace warning message with inline message when applying changes (authored by filipf). · Explain WhyJul 26 2019, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62613

View Options

kcms/fonts/fonts.h

Loading...
View Options

kcms/fonts/fonts.cpp

Loading...
View Options

kcms/fonts/package/contents/ui/main.qml

Loading...