KZip::openArchive: Remove "bad" assert
ClosedPublic

Authored by aacid on Jul 24 2019, 10:21 PM.

Details

Summary

There's nothing the caller of this function can do to control the assert
condition, so asserting is "too rude", and on top of that there's
a perfectly valid if below that already handles the condition properly

Diff Detail

Repository
R243 KArchive
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14393
Build 14411: arc lint + arc unit
aacid created this revision.Jul 24 2019, 10:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 24 2019, 10:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jul 24 2019, 10:21 PM
apol accepted this revision.Jul 24 2019, 10:52 PM
This revision is now accepted and ready to land.Jul 24 2019, 10:52 PM
aacid closed this revision.Jul 24 2019, 10:59 PM