Deprecate KRun::runService
Needs ReviewPublic

Authored by nicolasfella on Jul 23 2019, 11:01 PM.

Details

Reviewers
dfaure
Summary

A comment suggests to deprecate/remove it for KF6, but there's no reason we cannot deprecate it now

Diff Detail

Repository
R241 KIO
Branch
depre2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14364
Build 14382: arc lint + arc unit
nicolasfella created this revision.Jul 23 2019, 11:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2019, 11:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 23 2019, 11:01 PM
broulik added inline comments.
src/widgets/krun.h
239

Add @deprecated since and what should be used instead

  • Add @deprecated since
nicolasfella marked an inline comment as done.Jul 24 2019, 11:14 AM

Wait I'm having second thoughts about that comment :-)

Let's discuss this a bit later.