Differential D22663

Simplify OpenComposerJob using DBus activation.
ClosedPublic
Actions

Authored by dfaure on Jul 22 2019, 8:54 PM.

Details

Reviewers
vkrause
dvratil
Commits
R78:37194c150f6f: Simplify OpenComposerJob using DBus activation.
Summary

We could use QDBusPendingCallWatcher to keep this being async,
but I'm not sure it's worth the hassle, this won't block for long.

Test Plan

Builds. No idea how to test it.

Diff Detail

Repository
R78 PIM: Incidence Editor
Branch
Applications/19.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14300
Build 14318: arc lint + arc unit
dfaure created this revision.Jul 22 2019, 8:54 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 22 2019, 8:54 PM
dfaure requested review of this revision.Jul 22 2019, 8:54 PM
vkrause accepted this revision.Jul 23 2019, 8:56 AM
This revision is now accepted and ready to land.Jul 23 2019, 8:56 AM
Closed by commit R78:37194c150f6f: Simplify OpenComposerJob using DBus activation. (authored by dfaure). · Explain WhyJul 23 2019, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/opencomposerjob.h (4 lines)
Msrc/opencomposerjob.cpp (58 lines)

Diff 62351

View Options

src/opencomposerjob.h

Loading...
View Options

src/opencomposerjob.cpp

Loading...