Differential D22562

Add detectPlatform to always use wayland in a wayland session
ClosedPublic
Actions

Authored by fvogt on Jul 19 2019, 3:17 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:f765ffb186f0: Add detectPlatform to always use wayland in a wayland session
R224:2a687146ab80: Add detectPlatform to always use wayland in a wayland session
Summary

It's possible that Qt uses the xcb platform by default even in a Wayland
session, so detect such cases and switch to wayland instead to enable
proper support for remote input. Copy code from libkworkspace to not
introduce a dependency.

Test Plan

Started kdeconnectd, uses wayland platform now. Remote input works.

Diff Detail

Repository
R224 KDE Connect
Branch
1.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14134
Build 14152: arc lint + arc unit
fvogt created this revision.Jul 19 2019, 3:17 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJul 19 2019, 3:17 PM
fvogt requested review of this revision.Jul 19 2019, 3:17 PM
nicolasfella accepted this revision.Jul 19 2019, 3:19 PM
This revision is now accepted and ready to land.Jul 19 2019, 3:19 PM
fvogt closed this revision.Jul 19 2019, 5:57 PM
albertvaka added a subscriber: albertvaka.Jul 19 2019, 8:20 PM

Should this be merged to master in addition of 1.x?

fvogt added a comment.Jul 19 2019, 9:12 PM
In D22562#498171, @albertvaka wrote:

Should this be merged to master in addition of 1.x?

Yup, I attempted that shortly before dinner but got a ton of merge conflicts

Revision Contents
Changeset List

PathPackages
Mdaemon/kdeconnectd.cpp (27 lines)

Diff 62064

View Options

daemon/kdeconnectd.cpp

Loading...