When new results are added to the list, ensure KFind continues to display the results that user has scrolled to or selected.
Finally no more partial results constantly running away from cursor...
Details
Details
- Reviewers
ngraham davidedmundson - Group Reviewers
KFind - Commits
- R228:eee50d28df3d: [KFind] Natural auto-scrolling during new items insertion into search results…
Diff Detail
Diff Detail
- Repository
- R228 KFind
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kfindtreeview.cpp | ||
|---|---|---|
| 400 | Given this method is potentially called a lot it would be good to optimise it. We can return early with an empty list if selectedIndexes is empty. | |
| 427 | Rather than mapping to the source and back, it's safer to convert this to a QPersistentModelIndex, otherwise we're just relying on the assumption that the source model only appends. | |
| src/kfindtreeview.cpp | ||
|---|---|---|
| 400 | Good catch, thanks. | |
Comment Actions
LGTM too.
@broulik, the KAboutData says you're the maintainer. Are you good with this?
| src/kfindtreeview.cpp | ||
|---|---|---|
| 30 | fixed: includes in alphabetical order | |