Used it as much extensibly as I knew how to
Diff Detail
Diff Detail
- Repository
- R112 Milou
- Branch
- pc3 (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14112 Build 14130: arc lint + arc unit
| lib/qml/ResultDelegate.qml | ||
|---|---|---|
| 138 | Move that comment to where it belongs | |
| 142 | This should be a Svg from the Plasma Theme | |
| 168 | Where does that random 0.7 come from? | |
| 231 | QQC2 tooltip stuff doesn't really work for KRunner because they're not separate windows :( Also, don't use ToolTip attached property as it cannot respect the theme's delay settings | |
| lib/qml/ResultDelegate.qml | ||
|---|---|---|
| 231 |
Please don't change it. The alternative (using a ToolTip instance) is ridiculously heavy. | |
Comment Actions
The layout explodes for long category names, they should be elided.
The highlight isn't using Plasma theme anymore
The layout explodes for long category names, they should be elided.
The tooltips look quite bad and crammed because as I said they're not separate windows anymore. Also, they show up immediately instead of after a delay.
Clicking results doesn't do anything now, and there can now be both a highlight following the mouse and a selection following the keyboard.
| lib/qml/ResultDelegate.qml | ||
|---|---|---|
| 142 | Use whatever the PlasmaComponents.ListItem uses | |
| 234 ↗ | (On Diff #62007) | QQC2 tooltip doesn't seem to handle mnemonics, leading to text like "Run in &Terminal" |
Comment Actions
The highlight isn't using Plasma theme anymore
Of course it's using the theme, unless PlasmaComponents.ItemDelegate.highlighted doesn't use the theme, which then is a bug in plasma framework.
The layout explodes for long category names, they should be elided.
Fixed
The tooltips look quite bad and crammed because as I said they're not separate windows anymore.
Also, they show up immediately instead of after a delay.
Fixed, we could probably find a more generic fix.
Clicking results doesn't do anything now.
Fixed
and there can now be both a highlight following the mouse and a selection following the keyboard.
Would you prefer to change the current on hover? It's certainly doable but I'm not sure we want that.
| lib/qml/ResultDelegate.qml | ||
|---|---|---|
| 234 ↗ | (On Diff #62007) | Can't see that, see screenshot. |
Comment Actions
Selection highlights have regressed and text is no longer elided if it's too long, it just overflows.
