Differential D22513

Expose if we're still searching for more results
AbandonedPublic
Actions

Authored by apol on Jul 17 2019, 4:48 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Test Plan

Tested with a patch in plasma-workspace I'll upload shortly

Diff Detail

Repository
R112 Milou
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14051
Build 14069: arc lint + arc unit
apol created this revision.Jul 17 2019, 4:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 17 2019, 4:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jul 17 2019, 4:48 PM
broulik added a subscriber: broulik.Jul 18 2019, 12:31 PM
broulik added inline comments.
lib/sourcesmodel.cpp
43

From my testing this signal isn't realibly emitted, without D21606 and some other fix. See also Bug 381835
Are you sure this patch actually works?

apol added inline comments.Jul 18 2019, 7:54 PM
lib/sourcesmodel.cpp
43

It works, it just sometimes takes a lot of time to figure out that it ended. With my suggestion there it works much better.

apol marked an inline comment as done.Jul 24 2019, 11:37 PM
apol added inline comments.
lib/sourcesmodel.cpp
43

See D22723

davidedmundson accepted this revision.Aug 21 2019, 1:42 PM
This revision is now accepted and ready to land.Aug 21 2019, 1:42 PM
broulik added inline comments.Aug 21 2019, 1:43 PM
lib/sourcesmodel.h
45

In the new model it is "querying". Should we unify this?

apol added inline comments.Aug 22 2019, 1:24 AM
lib/sourcesmodel.h
45

Well that querying property renders this patch irrelevant. See D22514.

apol abandoned this revision.Aug 23 2019, 1:37 PM

Revision Contents
Changeset List

PathPackages
Mlib/qml/ResultsView.qml (1 line)
Mlib/sourcesmodel.h (6 lines)
Mlib/sourcesmodel.cpp (9 lines)

Diff 61924

View Options

lib/qml/ResultsView.qml

Loading...
View Options

lib/sourcesmodel.h

Loading...
View Options

lib/sourcesmodel.cpp

Loading...