As we now have per-identity auto-sign and auto-encrypt configuration,
users can now choose if they want to enable them when creating a new
account.
Details
Details
- Reviewers
- None
- Group Reviewers
KDE PIM - Maniphest Tasks
- T3129: Global switch for automatic crypto
- Commits
- R207:1d6172b1766d: AccountWizard: add option to configure default crypto behaviour for new identity
R43:8e20f90a1b63: AccountWizard: add option to configure default crypto behaviour for new identity
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| accountwizard/src/personaldatapage.cpp | ||
|---|---|---|
| 121 ↗ | (On Diff #5388) | create a enum for the states |
| accountwizard/src/personaldatapage.cpp | ||
|---|---|---|
| 4 ↗ | (On Diff #5388) | shouldn't we move the enum to the file namespace? So also other methods can use it? I would suggest to create a method aka: CryptoState PersonalDataPage::cryptoState() const{
return static_cast<CryptoState>(ui.cryptoComboBox->currentIndex());
} |
Comment Actions
@knauss shouldn't we move the enum to the file namespace? So also other methods can use it?
It's only relevant for the internal mapping here, nowhere else, there are no users outside and this is not public API anyway, so I don't see any point in that....