Add per-identity auto-encrypt option
ClosedPublic

Authored by dvratil on Jul 21 2016, 10:55 AM.

Details

Summary

We already have per-identity flag to automatically sign emails,
this change also adds a flag for per-identity encryption of emails.

Diff Detail

Repository
R176 PIM: KIdentity Management
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil updated this revision to Diff 5383.Jul 21 2016, 10:55 AM
dvratil retitled this revision from to Add per-identity auto-encrypt option.
dvratil updated this object.
dvratil edited the test plan for this revision. (Show Details)
dvratil added a reviewer: kde-pim.
dvratil added subscribers: mlaurent, aheinecke.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 21 2016, 10:55 AM

There is not a autotest for verify that identity set/restore correctly value.
Perhaps it's a good idea to start it :)

Could you create an autotest about it ?
Verify that we can copy identity, as 2 identity is same etc.

Thanks.

knauss accepted this revision.Jul 21 2016, 2:15 PM
knauss added a reviewer: knauss.
knauss added a subscriber: knauss.

sounds good for me.

This revision is now accepted and ready to land.Jul 21 2016, 2:15 PM

Hefee don't accept it when all comment is not fixed please !

"There is not a autotest for verify that identity set/restore correctly value.
Perhaps it's a good idea to start it :)

Could you create an autotest about it ?
Verify that we can copy identity, as 2 identity is same etc.

Thanks."

@mlaurent I wrote the unit-test and fixed a bunch of bugs that the test discovered. I will post it as separate review because the bugfixes are irrelevant to this change.

This revision was automatically updated to reflect the committed changes.