Differential D22443

Wrap text in copy/move confirmation dialog
ClosedPublic
Actions

Authored by gengisdave on Jul 13 2019, 4:43 PM.

Details

Reviewers
nmel
Group Reviewers
Krusader
Commits
R167:11ad2b9ef22d: Wrap text in copy/move confirmation dialog
R167:258d9d122600: Wrap text in copy/move confirmation dialog
Summary

When you want to copy/move a file with a very long name, the confirmation dialog is opened very wide to respect the filename width.

Wrapping the text let the dialog to be drawn at the usual width.

FIXED: [ 330788 ] "Information - Krusader" dialog does not fit to screen width; text non-copyable
BUG: 330788

Test Plan

No errors in the dialog window, like buttons drawn out of the visible area.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.Jul 13 2019, 4:43 PM
gengisdave created this revision.
nmel accepted this revision.Jul 20 2019, 6:44 AM
nmel added a subscriber: nmel.

It works fine but please fix coding style before pushing your changes. Thanks!

krusader/Dialogs/krdialogs.cpp
106

Please replace lbl with label according to the coding style.

This revision is now accepted and ready to land.Jul 20 2019, 6:44 AM
nmel added a comment.Jul 21 2019, 6:13 AM

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Closed by commit R167:11ad2b9ef22d: Wrap text in copy/move confirmation dialog (authored by gengisdave). · Explain WhyJul 21 2019, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkrusader/Dialogs/krdialogs.cpp (5 lines)

Diff 61707

View Options

krusader/Dialogs/krdialogs.cpp

Loading...