personsmodel: Add phoneNumber
ClosedPublic

Authored by jbbgameich on Jul 12 2019, 6:24 PM.

Details

Summary

This is intended to provide shared code for plasma-phone-components and spacebar.

Test Plan

The phoneNumber can be retrieved from the model

Diff Detail

Repository
R307 KPeople
Branch
personsmodel-phoneNumber (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13894
Build 13912: arc lint + arc unit
jbbgameich created this revision.Jul 12 2019, 6:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 12 2019, 6:24 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jbbgameich requested review of this revision.Jul 12 2019, 6:24 PM
jbbgameich updated this revision to Diff 61671.Jul 12 2019, 6:25 PM

fix indentation

bshah added a reviewer: apol.Jul 12 2019, 11:46 PM
apol added a comment.Jul 13 2019, 12:49 AM

Other than that LGTM

src/personsmodel.h
61

Put it after GroupsRole

jbbgameich updated this revision to Diff 61686.Jul 13 2019, 6:18 AM

Put PhoneNumberRole after GroupsRole

Does that mean it's ready to land now?

apol accepted this revision.Jul 15 2019, 1:06 AM

Thanks!

This revision is now accepted and ready to land.Jul 15 2019, 1:06 AM
jbbgameich closed this revision.Jul 15 2019, 7:22 AM