Simplifies the code and makes it more consistent with other settings
Details
Details
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Branch
- form
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13822 Build 13840: arc lint + arc unit
Comment Actions
Nice!
Are the "Security" and "IP Settings" headers really necessary, I wonder? I bet the two sections would look just fine with some whitespace or a separator, and no header text.
Comment Actions
Hi Nicolas,
thank you for your work on the mobile KCM. Since I'm not the author, but a student of mine is, I think I will leave your reviews for Nate and others as those are mostly Kirigami and UI changes and I don't even have a device to test them with. Unfortunately the student is most likely not going to work on this anymore and I haven't heard from him for a long time. Anyway, keep your good work and ignore me as a review blocker if Nate or anyone else accept the review. If you need any help from plasma-nm side, just don't hesitate to ask.