QApplication::desktop() is deprecated. It is advised to use
QGuiApplication::screens() instead.
Details
- Reviewers
apol - Group Reviewers
KWin - Commits
- R108:09f2d95a9ccf: Don't use deprecated QDesktopWidget
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
kcmkwin/kwinscreenedges/monitor.cpp | ||
---|---|---|
54 | Is there nicer way to retrieve QScreen from QWidget? |
kcmkwin/kwinscreenedges/monitor.cpp | ||
---|---|---|
54 | I'm not really sure it's that important. You have one preview, but the thing you're affecting changes all N screens. Showing dimensions of the primary screen is just as valid. Also the previous use of availableGeometry is almost certainly wrong. It's a preview of a monitor, therefore why exclude panels? |
kcmkwin/kwinscreenedges/monitor.cpp | ||
---|---|---|
54 |
Hmm, I just wanted to preserve current behavior. Am I missing something?
I have no idea, but yeah it doesn't make sense given that the monitor preview reflects dimensions of the screen on which the kcm is shown. |
Cool stuff!
I remember looking into QDesktopWidget years ago and finding it quite problematic as it triggered a shitload of QWidget events that we don't need here.