kcmkwin/kwinscreenedges/monitor.cpp
54	I'm not really sure it's that important. You have one preview, but the thing you're affecting changes all N screens. Showing dimensions of the primary screen is just as valid. Also the previous use of availableGeometry is almost certainly wrong. It's a preview of a monitor, therefore why exclude panels?

zzag added inline comments.Jul 10 2019, 2:33 PM

kcmkwin/kwinscreenedges/monitor.cpp
54	I'm not really sure it's that important. You have one preview, but the thing you're affecting changes all N screens. Hmm, I just wanted to preserve current behavior. Am I missing something? It's a preview of a monitor, therefore why exclude panels? I have no idea, but yeah it doesn't make sense given that the monitor preview reflects dimensions of the screen on which the kcm is shown.

Don't use availableGeometry.

Harbormaster completed remote builds in B13813: Diff 61516.Jul 10 2019, 2:43 PM

Cool stuff!
I remember looking into QDesktopWidget years ago and finding it quite problematic as it triggered a shitload of QWidget events that we don't need here.

This revision is now accepted and ready to land.Jul 10 2019, 2:54 PM

Closed by commit R108:09f2d95a9ccf: Don't use deprecated QDesktopWidget (authored by zzag). · Explain WhyJul 10 2019, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcmkwin/kwinoptions/windows.cpp (2 lines)
M			kcmkwin/kwinscreenedges/monitor.cpp (31 lines)
M			kcmkwin/kwintabbox/layoutpreview.cpp (4 lines)
M			kcmkwin/kwintabbox/main.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61512	9f0b74f		Jul 10 2019, 2:12 PM	★	★
Diff 2	61516	9f0b74f	Don't use availableGeometry.	Jul 10 2019, 2:43 PM	★	★
Diff 3	61546	28a4337	R108:09f2d95a9ccf6eeee7a93fe67d1006ac0d6d124c	Jul 10 2019, 7:50 PM	★	★