Differential D22330

adjust FlatButtonWithTooltip
ClosedPublic
Actions

Authored by astippich on Jul 8 2019, 5:46 PM.

Details

Reviewers
ngraham
mgallien
Commits
R255:d5711c7a8f8f: adjust FlatButtonWithTooltip
Summary

add default icon size
adjust accessibility and keyboard handling

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jul 8 2019, 5:46 PM
astippich created this revision.
astippich updated this revision to Diff 61364.Jul 8 2019, 6:23 PM
  • small fix
ngraham requested changes to this revision.Jul 9 2019, 12:51 PM

Hmm, with this patch, the buttons in the player bar no longer show a visible highlight when they have keyboard focus. They do actually get focus, and they now respond to the return key properly, but the visible highlight is lost.

This revision now requires changes to proceed.Jul 9 2019, 12:51 PM
astippich updated this revision to Diff 61425.Jul 9 2019, 4:35 PM
  • base it on a button again
astippich edited the summary of this revision. (Show Details)Jul 9 2019, 4:35 PM
In D22330#492790, @ngraham wrote:

Hmm, with this patch, the buttons in the player bar no longer show a visible highlight when they have keyboard focus. They do actually get focus, and they now respond to the return key properly, but the visible highlight is lost.

Oh thanks, did not notice. Happens because of the ToolButton, so I have reverted that part for now. Probably because of the style.

ngraham accepted this revision.Jul 9 2019, 6:27 PM

Shipit!

This revision is now accepted and ready to land.Jul 9 2019, 6:27 PM
Closed by commit R255:d5711c7a8f8f: adjust FlatButtonWithTooltip (authored by astippich). · Explain WhyJul 9 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/FlatButtonWithToolTip.qml (7 lines)

Diff 61446

View Options

src/qml/FlatButtonWithToolTip.qml

Loading...