Differential D22314

Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h
ClosedPublic
Actions

Authored by arojas on Jul 7 2019, 9:30 PM.

Details

Reviewers
dfaure
apol
Commits
R273:071048e32a89: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h
Summary

Since KF 5.60 kmodifierkeyinfoprovider_p.h depends on QSharedData, which is not wrapped in PyQt5, so sip can't generate bindings for it.

Test Plan

kguiaddons python bindings build correctly for the remaining classes

Diff Detail

Repository
R273 KGuiAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jul 7 2019, 9:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2019, 9:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Jul 7 2019, 9:30 PM
dfaure accepted this revision.Jul 7 2019, 9:31 PM
dfaure added a reviewer: apol.

Makes sense to me - this is private API anyway - but that makes me wonder why Aleix added it explicitly in commit 0fe2990dbad992a4? Oversight, or we're missing something?

This revision is now accepted and ready to land.Jul 7 2019, 9:32 PM
apol accepted this revision.Jul 7 2019, 11:23 PM
In D22314#492011, @dfaure wrote:

Makes sense to me - this is private API anyway - but that makes me wonder why Aleix added it explicitly in commit 0fe2990dbad992a4? Oversight, or we're missing something?

Yes, an oversight. Sorry.
Thanks for the patch @arojas!

Closed by commit R273:071048e32a89: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h (authored by arojas). · Explain WhyJul 7 2019, 11:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (1 line)

Diff 61300

View Options

src/CMakeLists.txt

Loading...