Differential D22302

fix kstart5 crash on wayland
ClosedPublic
Actions

Authored by garrison on Jul 7 2019, 6:55 AM.

Details

Reviewers
davidedmundson
Summary

Make kstart query NETRootInfo only if it is running on QX11Info::isPlatformX11 following porting guidelines.
Verified by starting just crashed plasmashell via 'kstart5 plasmashell'
BUG: 403965

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Lint Skipped
Unit
Unit Tests Skipped
garrison created this revision.Jul 7 2019, 6:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 7 2019, 6:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
garrison requested review of this revision.Jul 7 2019, 6:55 AM
garrison edited the summary of this revision. (Show Details)Jul 7 2019, 7:06 AM
davidedmundson accepted this revision.Jul 7 2019, 7:40 AM
This revision is now accepted and ready to land.Jul 7 2019, 7:40 AM
ngraham added a subscriber: ngraham.Jul 7 2019, 12:16 PM

@garrison, can you provide your email address so we can land this patch with correct authorship information? Thanks!

ngraham closed this revision.Jul 7 2019, 12:18 PM
ngraham added a subscriber: aacid.

Oh, this was already landed, but Phab didn't notice because its commit message was altered to no longer include the Differential Revision: https://phabricator.kde.org/D22302 text. Closing manually.

garrison added a comment.Jul 7 2019, 12:19 PM

anyway I confirm email address is correct - and will use git next time

aacid added a comment.Jul 7 2019, 4:09 PM
In D22302#491786, @ngraham wrote:

Oh, this was already landed, but Phab didn't notice because its commit message was altered to no longer include the Differential Revision: https://phabricator.kde.org/D22302 text. Closing manually.

Yeah, sorry about that, arc patch failed because of how the diff file was created and i forgot to manually add the differential line when recreating the commit

ngraham added a comment.Jul 7 2019, 6:02 PM

No worries!

When landing a patch that was originally branched from master onto a different branch, I find that the following works well for me: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Revision Contents
Changeset List

PathPackages
Mkstart/kstart.cpp (10 lines)

Diff 61264

View Options

kstart/kstart.cpp

Loading...