[Lock screen] Follow KDE title & subtitle style
ClosedPublic

Authored by filipf on Jul 3 2019, 9:05 AM.

Details

Summary

We're currently using a custom tyle for song titles and artist info in the lock screen's media controls.

This patch applies common KDE title & subtitle style as seen in e.g. Kickoff or plasma-nm applet-

Because the lock screen has increased font sizes, corrections for the title and subtitle have also been made.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 3 2019, 9:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2019, 9:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jul 3 2019, 9:05 AM
filipf edited the summary of this revision. (Show Details)Jul 3 2019, 9:06 AM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
broulik added a subscriber: broulik.Jul 3 2019, 9:32 AM
broulik added inline comments.
lookandfeel/contents/lockscreen/MediaControls.qml
132

Use PlasmaExtras.DescriptiveLabel instead

filipf updated this revision to Diff 61060.Jul 3 2019, 11:11 AM

use DescriptiveLabel for subtitle

filipf marked an inline comment as done.Jul 3 2019, 11:12 AM
filipf added a comment.Jul 4 2019, 9:10 PM

Ping, with D22230 landed this should also follow quite soon.

ngraham accepted this revision.Jul 4 2019, 10:52 PM
This revision is now accepted and ready to land.Jul 4 2019, 10:52 PM
This revision was automatically updated to reflect the committed changes.