Differential D22230

[TaskManager] Follow KDE title & subtitle style
ClosedPublic
Actions

Authored by filipf on Jul 3 2019, 8:58 AM.

Details

Reviewers
ngraham
hein
Group Reviewers
Plasma
VDG
Commits
R119:741ffda94294: [TaskManager] Follow KDE title & subtitle style
Summary

We're currently using a custom style for song titles and artist info in tooltips.

This patch applies the common KDE title & subtitle style as seen in e.g. Kickoff or plasma-nm applet.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 3 2019, 8:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2019, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jul 3 2019, 8:58 AM
filipf edited the test plan for this revision. (Show Details)Jul 3 2019, 9:00 AM
filipf added reviewers: Plasma, VDG, ngraham.
hein accepted this revision.Jul 3 2019, 9:30 AM
This revision is now accepted and ready to land.Jul 3 2019, 9:30 AM
filipf added a comment.Jul 3 2019, 11:17 AM

@hein would you want me to use PlasmaExtras.DescriptiveLabel for the subtitle, same as in D22231? Makes us not have to specify opacity.

hein added a comment.Jul 3 2019, 11:34 AM

@filipf: Yep, sounds sensible :)

filipf updated this revision to Diff 61062.Jul 3 2019, 11:39 AM

use DescriptiveLabel for subtitle/artist info

ngraham accepted this revision.Jul 3 2019, 2:04 PM
Closed by commit R119:741ffda94294: [TaskManager] Follow KDE title & subtitle style (authored by filipf). · Explain WhyJul 4 2019, 9:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61180

View Options

applets/taskmanager/package/contents/ui/ToolTipInstance.qml

Loading...